SGP 2.0.1 broken for Google Sign In

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

SGP 2.0.1 broken for Google Sign In

Pedrito
SGP does not work any longer on Google Sign's web page at https://www.google.com/accounts/ServiceLogin

This bug in SGP ≥ 2, preventing the SGP dialog to appear, in pages that SGP 1.3 had no troubles with always that I checked, has been there for ages. Ever since SGP was released, I would say.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

ChrisSGP
Administrator
Works fine for me with SGP 2.0 and 2.01, Firefox 4.0.1, OS X 10.6.5.

Can you report your browser and OS versions?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

rabbid10
I noticed it doesn't seem to work in IE8 or Chrome 11 on Windows XP.

EDIT:
I take it back.  It works in IE8 as long as you accept that it is not secure content on a secure page.  Chrome still seems to be giving me issues though.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

joshhidley
In reply to this post by ChrisSGP
It stopped working for me too, but only periodically. I'm in Chrome 11.0.696.65 on Windows 7.

If I go to www.google.com and click the Sign In button on the top right, I go to https://www.google.com/accounts/ServiceLogin?hl=en&continue=http://www.google.com/

This one doesn't work for me.

I tried just now, and can't find a place that google sign in works for me, but my apps account sign in works fine:
https://www.google.com/a/hidley.com/ServiceLogin?service=mail&passive=true&rm=false&continue=https%3A%2F%2Fmail.google.com%2Fa%2Fhidley.com%2F&bsv=llya694le36z&ss=1<mpl=default<mplcache=2

Thanks.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Mark Philpot
I can confirm that using Chrome for google sites, SGP has stopped working.  This is what the javascript console prints out:

Unsafe JavaScript attempt to access frame with URL https://accounts.youtube.com/accounts/CheckConnection?pmpo=https%3A%2F%2Fwww.google.com&v=-1166786220 from frame with URL https://www.google.com/accounts/ServiceLogin?service=mail&passive=true&rm=false&continue=http%3A%2F%2Fmail.google.com%2Fmail%2F%3Fui%3Dhtml%26zy%3Dl&bsv=llya694le36z&scc=1<mpl=default<mplcache=2. Domains, protocols and ports must match.

Looks like google is doing something with youtube.com which is causing the SGP bookmarklet to choke?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Mark Philpot
Alternatively, it might be a security thing in the latest Chrome releases that is preventing the javascript from executing.  
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Pedrito
In reply to this post by Pedrito
Also fails at https://login.yahoo.com

Running Chrome 11.0.696.68 on Mac OS X 10.6.7
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Pedrito
SuperGenPass 1.3 will work fine in those, though.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Mark Philpot
Is there a way to get the v1.3 bookmarklet?  It's not anywhere I can find on the sgp site.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Pedrito
You can find the link at <http://supergenpass.com/faq/#Technical-Details> along with some comments, one of which reveals why having to depend on v1.3 sucks:

Prior to version 2.0, SuperGenPass did not have full support for multibyte (loosely, non-ASCII) characters
The archive resides at <http://supergenpass.com/customize/?archive>. Another special version, seemingly identical but with support for adding salt, is at <http://supergenpass.com/customize/?advanced>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Buntaro
SGP 2 attempts to traverse all the FRAMEs on the current page to find all FORM elements. The problem is that some frames may be from a different domain and the browser prohibits the script to peek into them (to avoid cross-site scripting, or XSS).

In the function gp2_genpass() there are the following statements:

for(var i=0; i<Frames.length; i++) {
        for(var j=0; j<Frames[i].forms.length; j++) {
                ...
        }

It breaks if the 'Frames[i]' is from a different domain, thus 'Frames[i].forms' is undefined. I believe that code should be written this way:

for(var i=0; i<Frames.length; i++) {
        if(Frames[i] && Frames[i].forms) {
                for(var j=0; j<Frames[i].forms.length; j++) {
                ...
                }
        }
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

Pedrito
In reply to this post by ChrisSGP
Not a criticism, just so we know state of things.

Do you, ChrisSGP, consider this a non-issue, or do you plan on looking into it?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

FlavioSuarez
This post was updated on .
In reply to this post by Pedrito
It works for me (bookmarklet on Opera 11.11, Win7).
But I always go to https://gmail.google.com/gmail?nocheckbrowser
Give it a try...

[EDIT]
Sorry. I just realized that to login on Google I only use the Opera's Wand (password manager)...
[EDIT]
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

ChrisSGP
Administrator
In reply to this post by Pedrito
I plan on updating SGP soon. Obviously it's been neglected for awhile. I also plan to get it up on GitHub to make it easier for people to fork, should they so choose.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: SGP 2.0.1 broken for Google Sign In

DaneGolden
I too look forward to this fix. Particularly now that Firefox security will no longer be supported, I'm switching to Chrome as my primary browser on the available platforms (not iOS, of course). Thanks for SuperGenPass - it's an incredibly useful tool and an important part of my security regimen.
Loading...